client/connect: ConsulProxy LocalServicePort/Address #6358
Conversation
| @@ -1,12 +1,15 @@ | |||
| job "foo" { | |||
| datacenters = ["dc1"] | |||
|
|
|||
There was a problem hiding this comment.
I used hclfmt to clean up my own changes and it turns out this file was dirty. Apologies for the review noise.
|
Would it be at all valuable to expose these as a |
There was a problem hiding this comment.
Suggestions are just suggestions although we should get rid of those TODO and add these fields to https://www.nomadproject.io/docs/job-specification/proxy.html
tgross
force-pushed
the
f-connect-localserviceport
branch
4 times, most recently
from
5a36f83 to
074aa45
Compare
Without a `LocalServicePort`, Connect services will try to use the mapped port even when delivering traffic locally. A user can override this behavior by pinning the port value in the `service` stanza but this prevents us from using the Consul service name to reach the service. This commits configures the Consul proxy with its `LocalServicePort` and `LocalServiceAddress` fields.
tgross
force-pushed
the
f-connect-localserviceport
branch
from
074aa45 to
9a0f8a4
Compare
|
@schmichael thanks for catching those TODOs and suggesting some good language for them! I've addressed your comments, including adding docs here |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #6337
Without a
LocalServicePort, Connect services will try to use the mapped port even when delivering traffic locally. A user can override this behavior by pinning the port value in theservicestanza but this prevents us from using the Consul service name to reach the service.This commits configures the Consul proxy with its
LocalServicePortandLocalServiceAddressfields.