-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default update stanza and max_parallel=0 disables deployments #6191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with minor error message change) 🎉
Co-Authored-By: Chris Baker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Overview
This adds a default update stanza and makes
max_parallel=0
a sentinel value that disables deployments.max_parallel=1
update
stanza (even an empty one) are not affectedmax_parallel=0
in their update stanza will disable deployments (rolling and canary) explicitly, and make the job do forced updatesBehavior
Default update stanza
Service jobs have deployments when first submitted
Service jobs have rolling deployments when you submit a new version of the job
Batch jobs have no deployments and still perform destructive updates
max_parallel=0 disables deployments (i.e. the job will have destructive updates)
Implementation
Todo
max_parallel=0
is a sentinel value to indicate forced updates