Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hidden field from host volumes #6175

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

endocrimes
Copy link
Contributor

We're not shipping support for "hidden" volumes in 0.10 any more, I'll
convert this to an issue+mini RFC for future enhancement.

@endocrimes endocrimes added this to the 0.10.0 milestone Aug 21, 2019
@endocrimes endocrimes requested a review from langmartin August 21, 2019 18:35
@endocrimes endocrimes requested a review from jazzyfresh August 21, 2019 19:07
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after addressing the merge conflict

We're not shipping support for "hidden" volumes in 0.10 any more, I'll
convert this to an issue+mini RFC for future enhancement.
@endocrimes endocrimes force-pushed the dani/remove-hidden-vols branch from 29ca1a1 to 2d2b23d Compare August 22, 2019 06:48
@endocrimes endocrimes merged commit fbddb92 into master Aug 22, 2019
@endocrimes endocrimes deleted the dani/remove-hidden-vols branch August 22, 2019 06:49
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants