UI: Add allocation directory sorting #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn’t work in every instance; sometimes when I refresh there’s a failure. I’ll have to tune the models created to eliminate these occasional problems.
This will surely break under some circumstances; refinement to come.
This isn’t truly necessary but I think it makes it easier to understand the test.
This has a formatting problem where the sorting arrow overlaps with the heading label, but I’ll handle that separately.
Since directory sizes aren’t displayed (as they aren’t useful), this sort falls back to being by name for directories.
# Conflicts: # ui/app/controllers/allocations/allocation/task/fs.js # ui/app/templates/allocations/allocation/task/fs.hbs # ui/mirage/config.js # ui/tests/acceptance/task-fs-test.js # ui/tests/pages/allocations/task/fs.js
I almost never write controller tests but maybe this is more suitable than an acceptance test? 🧐
This change is unnecessary now that there’s specific data for the sorting test.
This opens the way for right-aligned columns to have a similar appearance, with the arrow immediately before the column heading.
Without this, changing the sort causes the column widths to change as well.
I thought this didn’t work yesterday…?? But it seems preferable to having the arrows take up space when tables get narrow.
This includes a merge, oops☹️
This feels a bit weird so far from the .is-selectable declarations, but I couldn’t get it to apply down there.
backspace
commented
Jul 4, 2019
DingoEatingFuzz
approved these changes
Jul 23, 2019
|
I removed the controller test. Thanks! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can try this out here. A GIF of it in action:
When sorting by size, directories are sorted by name, as size isn’t displayed.
This includes a change to the positioning of sort arrows for all tables, where this:
becomes this:
Because the directory table includes sortable right-aligned columns, having the arrow at the other edge of the cell sometimes makes it ambiguous which column it’s referring to. Moving the arrow beside the label is clearer. It’s also helpful in the directory viewer’s left-aligned “Name” column, which is comparatively quite wide, so the arrow otherwise was far away: