Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Ember Upgrade, Miscellaneous Dependencies #5514

Merged
merged 9 commits into from
Apr 8, 2019

Conversation

DingoEatingFuzz
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz commented Apr 3, 2019

This is step 3 of 4 for upgrading Ember. The goal of this step is to get the list of outdated packages as small as possible.

Master

yarn outdated --json | tail -n 1 | jq ".data.body | length"
50

f-ui-ember-v3

yarn outdated --json | tail -n 1 | jq ".data.body | length"
43

After

yarn outdated --json | tail -n 1 | jq ".data.body | length"
16

Granted it's okay to have out of date packages, and sometimes it's necessary (e.g., the current version of query-string doesn't support any version of IE), but 27 packages were still okay to upgrade.

The remaining dependencies fall in one of these categories:

  1. Ember > 3.4
  2. Bulma (intentionally not upgrading)
  3. Is large enough to be its own project (core-js, d3)

Code changes

Only four upgrades resulted in breaking changes.

  1. ember-cli-mirage: Mirage no longer likes models that are plural, so I singularized everything, even if it didn't make sense.
  2. ember-inline-svg: This was a minor upgrade, but should have been a major one since it upgraded its own dependency on svgo to a new major version. This change enabled an svgo plugin that was previously disabled by default. The fix was to configure ember-inline-svg to continue to not use that plugin.
  3. eslint: The object-spread rule was deprecated in favor of targeting ES2018
  4. lint-staged/husky: Husky now uses its own husky key in package.json to avoid polluting scripts. This is weird when used in conjunction with lint-staged, since lint-staged hid that detail.

@DingoEatingFuzz DingoEatingFuzz requested a review from a team April 3, 2019 17:51
@DingoEatingFuzz DingoEatingFuzz merged commit 66e4f9a into f-ui-ember-v3 Apr 8, 2019
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui-ember-v3-misc branch April 8, 2019 20:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant