UI: Ember 2.18 -> Ember 3.0 #5422
Conversation
ui/config/environment.js
Outdated
| @@ -21,7 +21,7 @@ module.exports = function(environment) { | |||
| }, | |||
|
|
|||
| APP: { | |||
| blockingQueries: true, | |||
| blockingQueries: false, | |||
There was a problem hiding this comment.
Is this change related to the upgrade?
There was a problem hiding this comment.
Nope! Good catch.
|
|
||
| hooks.beforeEach(function() { | ||
| this.subject = function() { | ||
| return this.owner.factoryFor('service:breadcrumbs').create(); |
There was a problem hiding this comment.
This boilerplate for unit testing a service is kind of a bummer, but understandable.
There was a problem hiding this comment.
There may be a better way to do this, such as something like setupSerializerTest(hooks), but I don't want to explore that until I make it to v3.4.
| this.getCodeMirrorInstance = getCodeMirrorInstance(this.owner); | ||
|
|
||
| // Expose to window for access from page objects | ||
| window.getCodeMirrorInstance = this.getCodeMirrorInstance; |
There was a problem hiding this comment.
Lol, it's not my proudest code, but Mirage also does this in a less obvious place. That's all the excuse I needed 😄
Since a future ember version does way with the need to manually making runloop runs, I'm holding off on those tests
DingoEatingFuzz
force-pushed
the
f-ui-ember-v3-3.0
branch
from
ba77ef8 to
616924c
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is step one in a process to upgrade to the latest Ember.js LTS version (3.4).
Major ember upgrades aren't as scary as minor upgrades, so this is a relatively safe PR.
The bulk of these changes were done with codemods that rewrote tests to the new testing style. The codemods aren't perfect and couldn't know about some of the custom testing stuff in Nomad, so there is also ~1000 lines of changes made by hand.