Re-enable Client GC tests #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani/b-gc-tests
branch
from
e01e8fa to
439120d
Compare
dadgar
requested changes
Dec 6, 2018
The previous integration test was broken during the client refactor, and it seems to be some sort of race with state updating. I'm going to try and construct a replacement test as part of work on performance, but for now, the underlying behaviour is still being tested.
endocrimes
force-pushed
the
dani/b-gc-tests
branch
from
439120d to
678ecdf
Compare
|
@dadgar I ended up fixing the integration test - ptal |
dadgar
approved these changes
Dec 6, 2018
endocrimes
force-pushed
the
dani/b-gc-tests
branch
from
678ecdf to
0d3a6d5
Compare
endocrimes
force-pushed
the
dani/b-gc-tests
branch
from
0d3a6d5 to
f6e2687
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renables the client garbage collection tests that were disabled
during the allocrunner refactor.
It also introduces a similar to the deprecated alloctestrunner interface
for debugging use. I'm planning on cleaning this up a bit more tomorrow
and probably renaming it, depending on if anything else is dependent.
The previous MaxAllocs test was actually an integration test that now
has some strange behaviour that I'm still working on resolving as part
of my work on GC performance. To unblock that work, I'm rming it for
now, and replacing the underlying MaxAllocs behaviour test with a
unit test.