Blocked evaluation fixes #4867
Merged
Blocked evaluation fixes #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic for cancelling duplicate blocked evaluations by job id had the issue where the newer evaluation could have additional node classes that it is (in)eligible for that we would not capture. This could make it such that cluster state could change such that the job would make progress but no evaluation was unblocked.
Blocked evaluation fixes
preetapan
reviewed
Nov 13, 2018
| t.Fatalf("bad: %#v", bStats) | ||
| } | ||
|
|
||
| // Add an older evaluation and assert it gets cancelled |
There was a problem hiding this comment.
Can you also add a test case for the other way around (add an eval thats older than the current one so that its marked as the duplicate)
There was a problem hiding this comment.
e1-e3 are that, e4 tests that we can cancel the incoming
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two blocked evaluation fixes:
Job tracking in the blocked eval tracker now handles namespaces
Improve cancelling of duplicate blocked evaluations such that new
information is not lost