-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Use stats trackers for resource rows #4726
Merged
DingoEatingFuzz
merged 4 commits into
f-ui-improved-stats-charts
from
f-ui-use-stats-trackers-for-resource-rows
Oct 17, 2018
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
65336cc
Use the StatsTracker method of getting alloc stats in alloc row
DingoEatingFuzz 4d5fa15
Remove no longer used allocation-stats class
DingoEatingFuzz 1e34a6a
Add utilization stats to the task rows on allocation detail
DingoEatingFuzz 2c20678
Add role="tooltip" to tooltips throughout the app
DingoEatingFuzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import Ember from 'ember'; | ||
| import Component from '@ember/component'; | ||
| import { inject as service } from '@ember/service'; | ||
| import { computed } from '@ember/object'; | ||
| import { alias } from '@ember/object/computed'; | ||
| import { task, timeout } from 'ember-concurrency'; | ||
| import { lazyClick } from '../helpers/lazy-click'; | ||
|
|
||
| export default Component.extend({ | ||
| store: service(), | ||
| token: service(), | ||
| statsTrackersRegistry: service('stats-trackers-registry'), | ||
|
|
||
| tagName: 'tr', | ||
| classNames: ['task-row', 'is-interactive'], | ||
|
|
||
| task: null, | ||
|
|
||
| // Internal state | ||
| statsError: false, | ||
|
|
||
| enablePolling: computed(() => !Ember.testing), | ||
|
|
||
| // Since all tasks for an allocation share the same tracker, use the registry | ||
| stats: computed('task', function() { | ||
| return this.get('statsTrackersRegistry').getTracker(this.get('task.allocation')); | ||
| }), | ||
|
|
||
| taskStats: computed('task.name', 'stats.tasks.[]', function() { | ||
| const ret = this.get('stats.tasks').findBy('task', this.get('task.name')); | ||
| return ret; | ||
| }), | ||
|
|
||
| cpu: alias('taskStats.cpu.lastObject'), | ||
| memory: alias('taskStats.memory.lastObject'), | ||
|
|
||
| onClick() {}, | ||
|
|
||
| click(event) { | ||
| lazyClick([this.get('onClick'), event]); | ||
| }, | ||
|
|
||
| fetchStats: task(function*() { | ||
| do { | ||
| try { | ||
| yield this.get('stats.poll').perform(); | ||
| this.set('statsError', false); | ||
| } catch (error) { | ||
| this.set('statsError', true); | ||
| } | ||
| yield timeout(500); | ||
| } while (this.get('enablePolling')); | ||
| }).drop(), | ||
|
|
||
| didReceiveAttrs() { | ||
| const allocation = this.get('task.allocation'); | ||
|
|
||
| if (allocation) { | ||
| this.get('fetchStats').perform(); | ||
| } else { | ||
| this.get('fetchStats').cancelAll(); | ||
| } | ||
| }, | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of question on this for my own benefit really:
aliasfor this?Ember.testingever change once things are running?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alias only works for paths on the object already (e.g.,
this.Ember.testing), so no.I just tried it and yes,
Ember.testingcan be changed at runtime, but it never happens from framework code.