Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send signals to tasks with dynamicsecrets in templates after agent restart #4707

Closed
wants to merge 2 commits into from
Closed

Send signals to tasks with dynamicsecrets in templates after agent restart #4707

wants to merge 2 commits into from

Conversation

tantra35
Copy link
Contributor

@tantra35 tantra35 commented Sep 20, 2018

This PR solve #4226

…hen task uses dynamicsecrets, it will be not notified that template rerendered(this happens alltimes when nomad agent restarts)
@nickethier
Copy link
Member

Closing this since the allocrunner and taskrunner have changed pretty drastically with the 0.9 release. If you want to rebase against master again we'll gladly look at a new PR. Sorry this languished due to all the 0.9 client refactor work

@nickethier nickethier closed this May 14, 2019
@tantra35
Copy link
Contributor Author

tantra35 commented Jun 14, 2019

@nickethier just check this behavior in nomad 0.9.3 and it doesn't solve #4226, so after restart nomad agent allocation that uses dynamic secrets after re-render

2019-06-14T19:54:04.886+0300 [INFO ] client.consul: discovered following servers: servers=192.168.142.102:4647,192.168.142.101:4647,192.168.142.103:4647
2019-06-14T19:54:04.902+0300 [INFO ] client: node registration complete
2019/06/14 19:54:04.975911 [INFO] (runner) creating new runner (dry: false, once: false)
2019/06/14 19:54:04.976172 [INFO] (runner) creating watcher
2019/06/14 19:54:04.976323 [INFO] (runner) starting
2019/06/14 19:54:05.208804 [INFO] (runner) rendered "(dynamic)" => "/var/lib/nomad/alloc/b8aff9c0-b257-d633-1674-ec3020049ca6/vault_debug_task/secrets/consul_token.env"

doesn't restarted

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants