UI: New job improved plan screen #4603
Conversation
DingoEatingFuzz
force-pushed
the
f-ui-new-job-improved-plan
branch
from
0308cd0 to
2d0805c
Compare
| const planOutput = yield this.get('model').plan(); | ||
| this.set('planOutput', planOutput.Diff); | ||
| yield this.get('model').plan(); | ||
| const plan = this.get('store').peekRecord('job-plan', this.get('model.id')); |
There was a problem hiding this comment.
Did you consider returning the JobPlan record from the adapter plan method? Reading this code, I had to go through the model to the adapter to verify that the peekRecord would work at this point. Returning a promise with a value instead might make the responsibility of the plan method clearer.
There was a problem hiding this comment.
Originally I wrote this as a relationship, then I noped out of there when planning multiple times didn't refresh the relationship on the job side and ended up at this place.
It made sense then to change what was job.get('jobPlan') to store.peekRecord at the call site, but I appreciate your fresh eyes here. Returning the new record from the plan method is much better.
I tested it out and it works, but I already refactored this code in the PR I'm about to open, so instead of making the change here, I'll make it there.
| JobRun.visit(); | ||
|
|
||
| andThen(() => { | ||
| JobRun.editor.fillIn(spec); |
There was a problem hiding this comment.
👌 I need to get around to grabbing this editor page object…
There was a problem hiding this comment.
This changes in my next PR too 😢
Since registerHelper only applies to acceptance tests, I have to do some Not Cool™ things to make this work in a component integration test.
| @@ -313,3 +316,52 @@ test('when submitting a job to a different namespace, the redirect to the job ov | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| test('when the scheduler dry-run has warnings, the warnings are shown to the user', function(assert) { | |||
| // Unschedulable is a hint to Mirage to respond with warnings from the plan endpoint | |||
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Part of the Job Writes project: #4600
When planning a job, nomad provides a "scheduler dry-run" which can be used to catch issues before the job is actually ran. Now this same output will be shown in the UI before running a job.