deployment improvements #4259
deployment improvements #4259
Conversation
…ocations and eventually has failed allocations
Also refactor Consul ServiceClient to take a struct instead of a massive set of arguments. Meant updating a lot of code but it should be far easier to extend in the future as you will only need to update a single struct instead of every single call site. Adds an e2e test for canary tags.
Guard against Canary being set to false at the same time as an allocation is being stopped: this could cause RemoveTask to be called with the wrong Canary value and leaking a service. Deleting both Canary values is the safest route.
…ce updated to be part of a new deployment
… and the deployment is updated.
preetapan
force-pushed
the
f-deployment-improvements
branch
from
6c3d522 to
4bc7db4
Compare
|
@preetapan can you please list the actual changes done here? I don't see any additions to changelog either - making it really hard to grok the impact of a PR with no public discussion and no real info on whats changed/improved |
|
@jippi I added details in the changelog ac2f070 and that links to documentation in c240e02#diff-7060727df807c472b4146d4812b64bf4 which will go live before we release 0.8.4. Can make the changelog entries more elaborate if what's there isnt clear |
|
@preetapan no, thats perfect, thanks! I got lost since it wasn't part of the PR :) |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR merges our feature branch that adds various enhancements to deployments, including introducing a progress deadline so that failed allocations during a deployment can be rescheduled and tagging canaries