Code

Drain v2: add controlled draining#4010

Code

Merged

schmichael merged 79 commits intomasterhashicorp/nomad:masterfrom f-drain-rebased2hashicorp/nomad:f-drain-rebased2Copy head branch name to clipboardMar 22, 2018

+6,318-702

Commits

Commits on Mar 21, 2018

• drain: initial drainv2 structs and impl

  schmichael

  committed
  95b3b6e

• testlog: override testlogger with envvar

  schmichael

  committed
  587d4e2

• mock_driver: improve Kill() logging

  schmichael

  committed
  91e8fd0

• RPC, FSM, State Store for marking DesiredTransistion

  Show description for 48d637d
  

  dadgar

  authored and

  schmichael

  committed
  48d637d

• drainer: switch to job based watching

  schmichael

  committed
  7deabe9

• switch to new raft DesiredTransition message

  schmichael

  committed
  832b1d5

• scheduler: migrate non-terminal migrating allocs

  Show description for a466f97
  schmichael

  committed
  a466f97

• improve drain fsm/statestore tests

  schmichael

  committed
  116c28c

• Node.Drain takes strategy

  

  dadgar

  authored and

  schmichael

  committed
  1773de9

• Drain cli, api, http

  

  dadgar

  authored and

  schmichael

  committed
  2bdeace

• Fix tests

  

  dadgar

  authored and

  schmichael

  committed
  762db7c

• Remove update time

  

  dadgar

  authored and

  schmichael

  committed
  fba20fd

• Upgrade path

  

  dadgar

  authored and

  schmichael

  committed
  a7833bc

• flag comment

  

  dadgar

  authored and

  schmichael

  committed
  5c101de

• RPC/FSM/State Store for Eligibility

  

  dadgar

  authored and

  schmichael

  committed
  dcafa8b

• HTTP and API

  

  dadgar

  authored and

  schmichael

  committed
  0fb9ba7

• node eligibility command

  

  dadgar

  authored and

  schmichael

  committed
  378c566

• Add eligibility to node view

  

  dadgar

  authored and

  schmichael

  committed
  d6399cb

• Unblock evals once eligible

  

  dadgar

  authored and

  schmichael

  committed
  451b77d

• Fix retaining the drain

  

  dadgar

  authored and

  schmichael

  committed
  a96c337

• Small refactor and cleanups

  

  dadgar

  authored and

  schmichael

  committed
  d65ae92

• code review

  

  dadgar

  authored and

  schmichael

  committed
  7d58209

• refactor drainer into a subpkg

  schmichael

  committed
  5be3263

• drainer: drainer should shutdown with server

  schmichael

  committed
  9de8908

• Remove unused context

  schmichael

  committed
  57c0335

• Restart every time SetEnabled(true) is called

  schmichael

  committed
  f2de735

• drainer: factor job & node watchers out of drainer.go

  schmichael

  committed
  678fbe1

• drainer: convert fsm errors to go errors

  schmichael

  committed
  3b25f78

• Improve DeadlineTime helper

  

  dadgar

  authored and

  schmichael

  committed
  3fe3c6e

• client: don't monitor health of non-service jobs

  Show description for 3ca9cdf
  schmichael

  committed
  3ca9cdf

• drainer: refactor newStopAllocs, applyMigrations

  schmichael

  committed
  1f73cd5

• refactor main drainloop into 2 more methods

  schmichael

  committed
  4782098

• Correct defaulting

  

  dadgar

  authored and

  schmichael

  committed
  7f98949

• Fix file names

  

  dadgar

  authored and

  schmichael

  committed
  a027016

• System test runs on mac

  

  dadgar

  authored and

  schmichael

  committed
  c00c02d

• Initial design

  

  dadgar

  authored and

  schmichael

  committed
  6026af2

• drain heap

  

  dadgar

  authored and

  schmichael

  committed
  e566fcd

• node watcher

  

  dadgar

  authored and

  schmichael

  committed
  da36810

• Node's being untracked or having updated deadlines, updates the deadliner

  

  dadgar

  authored and

  schmichael

  committed
  d45532d

• job watcher

  

  dadgar

  authored and

  schmichael

  committed
  0e51b20

• Drainer

  

  dadgar

  authored and

  schmichael

  committed
  cec2c5a

• integration test and basic fixes

  

  dadgar

  authored and

  schmichael

  committed
  c035422

• handle empty node case

  

  dadgar

  authored and

  schmichael

  committed
  fb40e8b

• Comments

  

  dadgar

  authored and

  schmichael

  committed
  4b4e234

• spelling fixes

  

  dadgar

  authored and

  schmichael

  committed
  bd70197

• code review

  

  dadgar

  authored and

  schmichael

  committed
  5b36af9

• Toggle Drain allows resetting eligibility

  Show description for d153714
  

  dadgar

  authored and

  schmichael

  committed
  d153714

• Switch to drainerv2 impl

  schmichael

  committed
  efb6601

• Fix deadline handling

  

  dadgar

  authored and

  schmichael

  committed
  45e7e88

• Batch drain update

  

  dadgar

  authored and

  schmichael

  committed
  ad2f211

• sharding

  

  dadgar

  authored and

  schmichael

  committed
  5324e56

• fix comment

  

  dadgar

  authored and

  schmichael

  committed
  270699b

• Fix node eligibility test

  schmichael

  committed
  fb6c821

• Add DesiredTransition.ShouldMigrate to api pkg

  schmichael

  committed
  6347bae

• Monitor node drains until completion in CLI

  Show description for 11d0eae
  schmichael

  committed
  11d0eae

• Improve drain log messages

  Show description for e669e82
  schmichael

  committed
  e669e82

• Fix deadline heap triggering

  Show description for 0a1f1d2
  schmichael

  committed
  0a1f1d2

• drainer: RegisterJob -> RegisterJobs

  Show description for 8217ebf
  schmichael

  committed
  8217ebf

• JobNs -> NamespacedID

  Show description for 74dc8fd
  schmichael

  committed
  74dc8fd

• Deregister garbage collected jobs

  schmichael

  committed
  8ef7863

• Remove debug prints

  schmichael

  committed
  e003b05

• Refactor assertOps into a helper func

  schmichael

  committed
  08c9116

• fix race in drain integration tests

  

  dadgar

  authored and

  schmichael

  committed
  98935b8

• rpcapi: remove; unused

  schmichael

  committed
  4efbc34

• Fix linting errors

  schmichael

  committed
  aab1fb7

• api: fix tests to expect default migrate strategy

  schmichael

  committed
  2bb1874

• alloc_runner: watch health for deployed batch jobs

  schmichael

  committed
  1537061

• mock: add BatchJob() helper

  schmichael

  committed
  9b88749

• tests: use mock.BatchJob to fix tests

  schmichael

  committed
  17161ec

• test: don't call t.Fatal from within a goroutine

  schmichael

  committed
  8088562

• test: try to prevent flakiness on travis

  schmichael

  committed
  50a94d7

• test: fix by using mock.BatchJob

  schmichael

  committed
  b8b1922

• test: disable drain during fsm test

  Show description for e8673b1
  schmichael

  committed
  e8673b1

• test: disable node drainer during tests

  Show description for 6366938
  schmichael

  committed
  6366938

• test: must initialize jobResults with new func

  schmichael

  committed
  ec09ea6

• remove spurious TODOs and FIXMEs

  schmichael

  committed
  b58a22c

• test: index no longer guaranteed on job list

  Show description for 07fe879
  schmichael

  committed
  07fe879

• docs: improve DrainRequest.MarkEligible comment

  schmichael

  committed
  3496bcf

• eligbile -> eligible

  schmichael

  committed
  e10883c