Monitor drains from CLI by default but allow detaching #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
f-drainv2-cli
branch
from
d36195c to
3af0332
Compare
allow -detach like other commands
schmichael
force-pushed
the
f-drainv2-cli
branch
from
3af0332 to
14d76fc
Compare
schmichael
changed the title
dadgar
approved these changes
Mar 15, 2018
command/node_drain.go
Outdated
|
|
||
| case !orig.DesiredTransition.ShouldMigrate() && a.DesiredTransition.ShouldMigrate(): | ||
| // Alloc marked for migration | ||
| msg = "draining" |
There was a problem hiding this comment.
msg = "marked for migration"
command/node_drain.go
Outdated
| // Alloc status has changed; output | ||
| msg = fmt.Sprintf("status %s -> %s", orig.ClientStatus, a.ClientStatus) | ||
|
|
||
| case !orig.DesiredTransition.ShouldMigrate() && a.DesiredTransition.ShouldMigrate(): |
There was a problem hiding this comment.
Can we add a case for the desired status changing and make that message, "draining"
| case orig.ClientStatus != a.ClientStatus: | ||
| // Alloc status has changed; output | ||
| msg = fmt.Sprintf("status %s -> %s", orig.ClientStatus, a.ClientStatus) | ||
|
|
There was a problem hiding this comment.
Can you add a case for NextAllocation != "" and then make the message, "replaced by allocation %q".
Also delay "node complete" after the node has been marked complete to capture a few more alloc events. There are other ways to implement this that could trade off correctness for responsiveness as technically a node is considered drained when all of its allocs have been marked to stop and not when they've actually stopped (which may not happen for a long time).
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output from 5c4ffd4:
Original output from 8b7b42c: