Test QEMU graceful shutdown #3819
Conversation
Uses an Alpine image which supports ACPI poweroff signal handling. Handling is only enabled after the VM has booted, so this test blocks until sshd starts before issuing the command.
schmichael
changed the title
Hopefully we can reuse the SkipSlow helper elsewhere.
GNUmakefile
Outdated
| @@ -245,6 +245,7 @@ test-nomad: dev ## Run Nomad test suites | |||
| @echo "==> Running Nomad test suites:" | |||
| @NOMAD_TEST_RKT=1 \ | |||
| go test $(if $(VERBOSE),-v) \ | |||
| -v \ | |||
There was a problem hiding this comment.
remove this, because all the changes I made in PR #3626 were because we thought that Travis should not have verbose logging.
There was a problem hiding this comment.
Ack, thanks for catching that. The entire 7b8d9d4 commit was intended to be a temporary test and reverted. Killing it now.
| Driver: "qemu", | ||
| Config: map[string]interface{}{ | ||
| "image_path": "linux-0.2.img", | ||
| "accelerator": "tcg", |
There was a problem hiding this comment.
what is accelerator and why do we not need it anymore
There was a problem hiding this comment.
It is the default if accelerator is not specified:
Lines 218 to 221 in 32174fd
QEMU has a number of accelerators depending on the host and vm architectures. I think tcg is the best you can get when you run in as many different environments as our tests do (linux hosts, virtualbox, vmware, travis).
At any rate this test shouldn't have anything to do with the accelerator being used, so I'd rather let it use the default than imply the test actually cares about the accelerator by specifying it.
|
|
||
| via https://en.wikibooks.org/wiki/QEMU/Images | ||
|
|
||
| Does not support graceful shutdown. |
There was a problem hiding this comment.
Is there a reason why we should keep both images around?
There was a problem hiding this comment.
The other one will live forever in git's history, so there's not much benefit in dropping it. It's also very small and fast, and so for tests that don't care about what's running in the VM it's ideal.
client/driver/qemu_test.go
Outdated
|
|
||
| select { | ||
| case <-resp.Handle.WaitCh(): | ||
| // VM exited gracefully! |
There was a problem hiding this comment.
Maybe test-level logging?
| @@ -14,7 +14,7 @@ if [ "$RUN_STATIC_CHECKS" ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| make test | |||
| NOMAD_SLOW_TEST=1 make test | |||
There was a problem hiding this comment.
Define a make flag to optionally run these locally
There was a problem hiding this comment.
I am not sure why we need a make flag, eg I set TRAVIS=1 to pretend to be travis when running locally, and can similarly set NOMAD_SLOW_TEST=1 too.
There was a problem hiding this comment.
What does TRAVIS=1 do? I know we intentionally lower the parallelism and raise timeouts when running on Travis which you do not want when running this slow test as it would only make it run more slowly.
I was trying to follow the example of NOMAD_TEST_RKT with this, although I guess their naming schemes differ.
|
LGTM |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
There's a lot going on here as this feature has proven quite hard to test:
system_powerdowncommand.git-lfsto manage the new 40MB Alpine image and hopefully make future image/large-file changes easier to manage.SlowTest(t)test helper to skip slow tests unlessNOMAD_SLOW_TEST=1is set (it is set in Travis). Right now only theQemuDriver_GracefulShutdowntest has this check as it takes 40s or more to run and adds about 20s to the driver packages run time even when run in parallel with other tests.