Network config #33
Network config #33
Conversation
| // Setup the configuration | ||
| // serverConfig is used to generate a new server configuration struct | ||
| // for initializing a nomad server. | ||
| func (a *Agent) serverConfig() (*nomad.Config, error) { | ||
| conf := a.config.NomadConfig | ||
| if conf == nil { | ||
| conf = nomad.DefaultConfig() |
There was a problem hiding this comment.
Maybe this is not the best spot, but can we log when we're decide to use the default config? In case we get into a weird spot like, "Why are none of my config values working? Oh it's using defaults."
There was a problem hiding this comment.
We could do something like that yeah. Maybe when we start the agent we can do a debug log and dump the names of the config files or something like that, so at least we would have a way to easily see if something wasn't getting picked up. I'll add a ticket for that.
|
👍 A few comments but no blockers. LGTM! |
Update StableStore documentation based on hashicorp#29
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds network configuration to the agent. This lets us specify bind addresses / ports as well as the advertise addrs for RPC and Serf. The
BindAddrat the top-most level of the config can be used to specify the default bind address, which all of the individual bind addrs will fall back to if not provided with a specific config.Also updated testutil/server to use these port settings so we can spin up multi-node Nomad clusters in our tests.