Ensure allocDir is never nil and persisted safely #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
changed the title
schmichael
force-pushed
the
b-alloc-dir-fixes
branch
from
3f7919d to
bf5c18d
Compare
jippi
reviewed
Jul 14, 2017
client/alloc_runner.go
Outdated
| } | ||
| // Build allocation directory (idempotent) | ||
| if err := r.allocDir.Build(); err != nil { | ||
| r.logger.Printf("[WARN] client: failed to build task directories: %v", err) |
schmichael
changed the title
Task dir metadata is created in AllocRunner.Run which may not run before an alloc is sync'd and Nomad exits. There's no reason not to just create task dir metadata on restore if it doesn't exist.
Since the AllocRunner.alloc struct can be mutated, most of AllocRunner needs to acquire a lock to get the alloc's ID. Log lines always need to include the alloc ID, so we often skipped acquiring a lock just to grab the ID and accepted the race. Let's make the race detector a little happier by storing the ID in a single assignment field.
schmichael
force-pushed
the
b-alloc-dir-fixes
branch
from
860a9ed to
b0eae2f
Compare
dadgar
approved these changes
Jul 18, 2017
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2834
Sorry for the PR noise by adding the
AllocRunner.allocIDfield. It was part of a larger effort I mostly abandoned but wanted to keep that bit.