Log impilict constraints to log if level=trace #25233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raints considered in an evaluation.
…raints considered in an evaluation.
…execution commands. provision order: - './scripts/linux-priv-go.sh' requires `curl`, that is installed by './scripts/linux-priv-config.sh'
tgross
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Hi @softwaremastermind! The job inspect command already includes all this information because its persisted to Raft. I'm having trouble imagining a debugging scenario where it'd be more useful to have this in logs (typically available only to the cluster admin) vs the job inspect (available to any job author).
Do you typically run with trace logging enabled? I worry this could get really expensive for busy clusters when running tools like nomad operator debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request resulted from a troubleshooting process in an internal Nomad cluster. Before Nomad performs an evaluation, it adds a set of implicit constraints to a job (Job#admissionMutators).
The information about all implicit constraints considered in the log files would have supported troubleshooting. This merge request offers code that logs the implicit constraints when the log level is
trace.Testing & Reproduction steps
I have made some minor changes to the Vagrant setup to run Vagrant on Ubuntu 24.04.2 LTS.
Links
Scheduling in Nomad
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.