Fix TLS use in AllocFS API and region/dc detection #2490
Conversation
api/agent.go
Outdated
| @@ -60,10 +60,10 @@ func (a *Agent) populateCache(self *AgentSelf) { | |||
| a.nodeName = self.Member.Name | |||
| } | |||
| if a.datacenter == "" { | |||
| a.datacenter, _ = self.Member.Tags["dc"] | |||
| a.datacenter, _ = self.Config["Datacenter"].(string) | |||
There was a problem hiding this comment.
I would feel more comfortable if we validate the value existed to avoid panics
There was a problem hiding this comment.
Technically this code is panic-safe, but it's overly clever so I'll fix it :)
(The 2 form assignment applies to the type assertion, so if the key doesn't exist it returns interface{}(nil) which when 2-form-assignment-asserted to string gives you the empty string which datacenter is anyway! Way too "clever" https://play.golang.org/p/5jcXxfdthi )
|
Would mark the issue this fixes. LGTM |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #2290