event stream: refactor to use Eventer interface #24738
Draft
+268
−413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `Eventer` interface to the core structs so they can emit their own events, and use this to refactor the `eventFromChange` function at the core of the event stream.
|
Leaving a note here that I don't love this approach. I suspect (but haven't yet checked) that none of these functions will get inlined across packages. This drags the event construction away from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental
Add an
Eventerinterface to the core structs so they can emit their own events, and use this to refactor theeventFromChangefunction at the core of the event stream.Ref: #24721 (comment)