Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: change stop_after to stop_on_client_after #24727

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Docs: change stop_after to stop_on_client_after #24727

merged 2 commits into from
Dec 19, 2024

Conversation

aimeeu
Copy link
Contributor

@aimeeu aimeeu commented Dec 19, 2024

Description

Change stop_after to stop_on_client_after.
Update examples.
Move disconnect entry to correct alphabetical order in nav.
Looks like the code change was part of 1.8, so not backporting to 1.7.

Links

Jira: CE-800
GH Issue: #24702
Deploy preview

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@aimeeu aimeeu added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line backport/1.9.x backport to 1.9.x release line labels Dec 19, 2024
@aimeeu aimeeu requested review from a team as code owners December 19, 2024 18:57
@aimeeu aimeeu requested a review from prestonbourne December 19, 2024 18:57
@aimeeu aimeeu removed the request for review from prestonbourne December 19, 2024 19:02
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aimeeu!

@aimeeu aimeeu merged commit 1c12fc5 into main Dec 19, 2024
16 checks passed
@aimeeu aimeeu deleted the ce800 branch December 19, 2024 19:14
aimeeu added a commit that referenced this pull request Dec 19, 2024
* change stop_after to stop_on_client_after

CE-800  GH #24702

* Move disconnect entry to correct alphabetical place in nav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.8.x backport to 1.8.x release line backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants