-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event stream: add events for CSI volumes and plugins #24724
Conversation
a907c58
to
b6db2cf
Compare
b6db2cf
to
faffbf2
Compare
faffbf2
to
a0f3b46
Compare
Adds new topics to the event stream for CSI volumes and CSI plugins. We'll emit event when either is created or deleted, and when CSI volumes are claimed.
a0f3b46
to
0781ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
return false | ||
} | ||
case structs.TopicCSIPlugin: | ||
if ok := aclObj.AllowNsOp(subReq.Namespace, acl.NamespaceCapabilityReadJob); !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was ReadJob
selected because the CSIPlugin
contains alloc information (and whatever JobDescriptions
is)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Although the reason we're using it here is because the CSIPlugin.Read
RPC handler uses the same permission, and they should match 😁
Adds new topics to the event stream for CSI volumes and CSI plugins. We'll emit events when either is created or deleted, and when CSI volumes are claimed.
Ref: #24721
Description
Testing & Reproduction steps
In addition to the unit tests, you can use nomad operator api "/v1/event/stream?topic=CSIVolume" to poll for CSI volume events while running the host path demo.
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.