Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stateful deployments: validate there are no sticky per_alloc volume requests #24714

Merged
merged 1 commit into from
Dec 19, 2024
Merged

stateful deployments: validate there are no sticky per_alloc volume requests #24714

merged 1 commit into from
Dec 19, 2024

Conversation

pkazmierczak
Copy link
Contributor

This changeset adds an additional validation that prevents users from setting per_alloc and sticky flags on volume requests.

Ref: #24479

@pkazmierczak pkazmierczak requested review from a team as code owners December 19, 2024 09:33
tgross
tgross approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkazmierczak pkazmierczak merged commit 6ea52e4 into dynamic-host-volumes Dec 19, 2024
17 checks passed
@pkazmierczak pkazmierczak deleted the f-per-alloc-sticky-validate branch December 19, 2024 14:20
tgross pushed a commit that referenced this pull request Dec 19, 2024
@pkazmierczak @tgross
stateful deployments: validate there are no sticky per_alloc volume r…
ad1e597 
…equests (#24714)

This changeset adds an additional validation that prevents users from setting
per_alloc and sticky flags on volume requests.

Ref: #24479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkazmierczak @tgross