Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Update e2e tests to match new e2e infra Nomad region name. #24713

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Dec 19, 2024

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

tgross
tgross previously approved these changes Dec 19, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrasell!

Something not being accounted for here is that the region is a variable, so if it were changed these tests would fail again. As far as I know you can safely leave Region out of QueryOptions entirely (the behavior around that was what we fixed in the PR that changed the region). That would leave the CNI test that explicitly is looking for the region but we could query the cluster for its region first or use some other value in the logs for the assertion (the test itself isn't about "regions" as a concept).

I'm going to approve in case you don't feel like dealing with any of that for now. 😁

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell merged commit 8bb7c13 into main Dec 19, 2024
28 checks passed
@jrasell jrasell deleted the b-fix-e2e-test-region-name branch December 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants