Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic host volumes: add -type flag to volume init #24667

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 13, 2024

Adds a -type flag to the volume init command that generates an example volume specification with only those fields relevant to dynamic host volumes. This changeset also moves the string literals into uses of go:embed

Ref: #24479

Adds a `-type` flag to the `volume init` command that generates an example
volume specification with only those fields relevant to dynamic host
volumes. This changeset also moves the string literals into uses of `go:embed`

Ref: #24479
@tgross tgross force-pushed the dhv-cli-volume-init branch from cb8d756 to a4d47aa Compare December 13, 2024 20:13
@tgross tgross marked this pull request as ready for review December 13, 2024 20:14
@tgross tgross requested review from a team as code owners December 13, 2024 20:14
@tgross tgross requested a review from pkazmierczak December 13, 2024 20:14
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit 97d9269 into dynamic-host-volumes Dec 16, 2024
17 checks passed
@tgross tgross deleted the dhv-cli-volume-init branch December 16, 2024 14:11
tgross added a commit that referenced this pull request Dec 19, 2024
Adds a `-type` flag to the `volume init` command that generates an example
volume specification with only those fields relevant to dynamic host
volumes. This changeset also moves the string literals into uses of `go:embed`

Ref: #24479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants