Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show HCL variable input on job submission. #24622

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

sevensolutions
Copy link
Contributor

@sevensolutions sevensolutions commented Dec 7, 2024

Description

This PR will show the text area for entering HCL variable values on job submission, as suggested in #23582.
It was already shown when editing a job using the UI, but not when submitting a new job.
The underlying model already supports the this, only the UI was missing.

Testing & Reproduction steps

  • Submit a new job using variables
  • Enter the variables in the new text area below the job spec

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

philrenaud
philrenaud previously approved these changes Dec 17, 2024
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sevensolutions this looks and works great. Nice job and thanks for the contribution!

Would you mind adding a changelog entry by running make cl? With that, I would be happy to see this merged.

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Dec 17, 2024
@philrenaud philrenaud merged commit 04e930b into hashicorp:main Dec 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants