Backport of [gh-24339] Move from streaming stats to polling for docker into release/1.9.x #24527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24525 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
Description
It addresses 24339.
Currently to get the stats from a container we are using the call to
ContainerStats
which returns a stream of data that can be reused, but it only works if the sampling interval for the metrics is1s
exactly. With other values, decoding errors start to show up and the metric values becomes inconsistent:It might have gone unnoticed because the error messages were displayed only for debug, which rarely happens on production environments.
To avoid the sync problem, this PR introduces a polling call to the stats endpoint, which is not as efficient, but is more versatile and allows for different sampling intervals.
Testing & Reproduction steps
To see the bug, take the latest release and start a nomad agent, it can be in -dev mode, with telemetry enabled and a
collection_interval
different from1s
.Run a job with multiple allocations and after a while the errors will show and the metrics for the allocations will be unstable.
Links
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Overview of commits