Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of consul: handle nil multierror pointer correctly into release/1.9.x #24516

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #24513 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


When the service client syncs to Consul, we accumulate service sync errors in a multierror before reading all the local checks. If the API call to the local checks fails, we either return that error or append it to the multierror and return the set of errors. But multierror.Error.Len() doesn't nil-check, so we need to do this ourselves.

I've also made a quick pass through the rest of the code base looking for multierror Len method calls to see if we have this pattern elsewhere.

Fixes: #24512


Overview of commits

@tgross tgross merged commit 824ce0c into release/1.9.x Nov 20, 2024
20 checks passed
@tgross tgross deleted the backport/consul-multierr-panic/eagerly-calm-elephant branch November 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants