Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: fix ipv6 bind_address test #24216

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

gulducat
Copy link
Member

I realized this test I wrote in #24203 didn't actually test the IPv6-detection logic, because "bind_address": "::" was being passed in as config, effectively bypassing the important bit here:

if _, ok := cfg["bind_address"]; !ok {
cfg["bind_address"] = connectProxyBindAddress(networks)
}

@gulducat gulducat added the backport/1.9.x backport to 1.9.x release line label Oct 15, 2024
@gulducat gulducat merged commit a0d7fb6 into main Oct 16, 2024
29 checks passed
@gulducat gulducat deleted the fix-connect-bind_address-test branch October 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants