Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quotas: corrections to Resources.Add and quota apply parsing logic #23894

Merged
merged 2 commits into from
Sep 9, 2024
Merged

quotas: corrections to Resources.Add and quota apply parsing logic #23894

merged 2 commits into from
Sep 9, 2024

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak added this to the 1.9.0 milestone Aug 30, 2024
@pkazmierczak pkazmierczak self-assigned this Aug 30, 2024
@pkazmierczak pkazmierczak requested a review from tgross September 9, 2024 08:46
tgross
tgross approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkazmierczak pkazmierczak merged commit 2e6ccf8 into main Sep 9, 2024
19 checks passed
@pkazmierczak pkazmierczak deleted the f-quota-resources-corrections branch September 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@shoenig shoenig Awaiting requested review from shoenig

@jrasell jrasell Awaiting requested review from jrasell

Assignees

@pkazmierczak pkazmierczak

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

extend quotas to include device plugins such as GPUs
2 participants
@pkazmierczak @tgross