Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Show "Scaled Down" as a valid job status when task groups' counts are set to zero #23829

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[ui] Show "Scaled Down" as a valid job status when task groups' counts are set to zero #23829

merged 3 commits into from
Aug 19, 2024

Conversation

philrenaud
Copy link
Contributor

Resolves #23591

@philrenaud philrenaud self-assigned this Aug 15, 2024
@philrenaud philrenaud linked an issue Aug 15, 2024 that may be closed by this pull request
Nomad UI shows failed for jobs that are scaled to 0 #23591
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

Ember Test Audit comparison

main 0082955 change
passes 1578 1578 0
failures 0 0 0
flaky 0 0 0
duration 11m 37s 096ms 11m 51s 173ms +14s 077ms

@philrenaud philrenaud mentioned this pull request Aug 15, 2024
Closed
@philrenaud philrenaud marked this pull request as ready for review August 19, 2024 13:22
pkazmierczak
pkazmierczak approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label Aug 19, 2024
@philrenaud philrenaud merged commit 5fcec1f into main Aug 19, 2024
18 checks passed
@philrenaud philrenaud deleted the 23591-nomad-ui-shows-failed-for-jobs-that-are-scaled-to-0 branch August 19, 2024 17:45
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 19, 2024
Merged
@philrenaud philrenaud mentioned this pull request Aug 21, 2024
Merged
@philrenaud philrenaud mentioned this pull request Dec 6, 2024
Merged
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Dec 17, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkazmierczak pkazmierczak pkazmierczak approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees

@philrenaud philrenaud

Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad UI shows failed for jobs that are scaled to 0
2 participants
@philrenaud @pkazmierczak