Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minimal Consul policy for Nomad agents needs node:write #23800

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Aug 13, 2024

Since Consul 1.15 (hashicorp/consul#16097) Consul client agent only uses the agent token to perform anti-entropy after you deregister a service via the Agent API. so the Consul client agent must have its own agent token.

Internal ref: https://hashicorp.atlassian.net/browse/NET-10360
Fixes: #23800

@pkazmierczak pkazmierczak requested review from shoenig and tgross August 13, 2024 15:46
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak added the backport/website This will backport PR changes to `stable-website` && the latest release-branch label Aug 13, 2024
@pkazmierczak pkazmierczak deleted the b-consul-node-write branch August 13, 2024 15:51
@pkazmierczak pkazmierczak restored the b-consul-node-write branch August 13, 2024 15:51
@pkazmierczak pkazmierczak reopened this Aug 13, 2024
@pkazmierczak pkazmierczak added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line and removed backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent labels Aug 13, 2024
@pkazmierczak pkazmierczak merged commit c1362c0 into main Aug 13, 2024
28 checks passed
@pkazmierczak pkazmierczak deleted the b-consul-node-write branch August 13, 2024 15:53
@pkazmierczak pkazmierczak removed the backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent label Aug 13, 2024
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants