Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static ports duplication on network host with multiple matches #23702

Conversation

sbenoistmics
Copy link
Contributor

When a client add two IP matching the same network host, it should be able to used both for static ports
The primary used case is when an application with not configurable port is deployed on a big bare metal host. It would be wasteful to not allow multiple time the same host to be used.

Fixes: #23693

Copy link

hashicorp-cla-app bot commented Jul 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution!

Let me know what you think of the changelog wording, and we'll get this merged.

.changelog/23693.txt Outdated Show resolved Hide resolved
@gulducat gulducat added theme/networking backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line labels Jul 30, 2024
Co-authored-by: Daniel Bennett <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line theme/networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one IP is recognized on host_network
2 participants