e2e: test cni args #23597
Merged
e2e: test cni args #23597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
approved these changes
Jul 15, 2024
| "type": "cni_args.sh" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
This file is missing a EOL at the end of the file, which will mess up various unix tools (ex. try running wc -l on this file and you'll see it'll only have 8 lines!). You should be able to fix-on-save in your editor.
|
|
||
| set -euo pipefail | ||
|
|
||
| # things are prefixed with "Fancy*" because this is a fancy plugin. |
There was a problem hiding this comment.
Daniel did this if you can tell 🤣
Co-authored-by: Daniel Bennett <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an e2e test for cni args implemented in #23538.
The test uses a job specification with a custom cni plugin "cni_args.sh" to write a file containing an interpolated variable passed in as a cni arg to the task local folder. Then the test makes sure that this file exists in the correct location and checks that the value was written and interpolated correctly.