Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] When a job is deleted in the background, wait until redirect before cache unload into release/1.8.x #23507

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #23492 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

The below text is copied from the body of the original PR.


This prevents an issue where, still on the job page, the cache-removed job would have trouble accessing properties and relationships of its now-removed Ember Data object.

Resolves #23410


Overview of commits

Copy link

github-actions bot commented Jul 4, 2024

Ember Test Audit comparison

release/1.8.x 0027504 change
passes 1564 1564 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit 6b4b895 into release/1.8.x Jul 8, 2024
15 of 16 checks passed
@philrenaud philrenaud deleted the backport/23410-ui-cannot-close-task-sidebar-if-job-was-deleted/briefly-relaxing-teal branch July 8, 2024 03:14
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants