Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Jobs list should handle 502s and 504s gracefully into release/1.8.x #23447

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #23427 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

The below text is copied from the body of the original PR.


Previously, our jobs index page would handle handle all errors when fetching jobs by resetting state and trying again (with 5-second backoff).

This PR makes it so that proxy-timeout specific errors instead throw a notification, but keep the cached jobs shown on the page.

The user is then presented with two options to move forward:

  • pause fetch attempts (for this session or until they click "Manually fetch jobs")
  • Immediately try again (in case they extended their proxy settings in the background and want to immediately cancel pending requests and try again, or restart previously-paused attempts)

Resolves #23228
image


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/23228-ui-the-jobs-page-shows-no-jobs-found-after-being-idle-for-two-minutes/actively-stunning-swift branch from 00c78f8 to c54235a Compare June 27, 2024 01:51
Copy link

Ember Test Audit comparison

release/1.8.x c54235a change
passes 1563 1564 +1
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit 837bf14 into release/1.8.x Jun 27, 2024
15 of 16 checks passed
@philrenaud philrenaud deleted the backport/23228-ui-the-jobs-page-shows-no-jobs-found-after-being-idle-for-two-minutes/actively-stunning-swift branch June 27, 2024 03:12
Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants