Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Rework of node/job attributes/meta using PathTree into release/1.8.x #23311

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #23290 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

The below text is copied from the body of the original PR.


This extends and reuses PathTree logic originally written for Variables in #13202

This PR specifically fixes a bug where a metadata k/v item wouldn't show up in the UI if its full key was the prefix of a nested child key.

For example, this metadata:

{
  'phil.hair': 'yes',
  'phil.hair.colour': 'black',
  'phil.hair.length': 'short'
};

would produce the following:
image

and now produces:
image


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/16034-ui-bug-node-metadata-doesnt-show-up-in-the-ui-when-key-is-also-a-prefix-for-others/badly-obliging-walleye branch from 052797b to 5084269 Compare June 12, 2024 18:28
Copy link

Ember Test Audit comparison

release/1.8.x 5084269 change
passes 1564 1563 -1
failures 0 0 0
flaky 0 0 0
duration 11m 45s 101ms 11m 37s 172ms -07s 929ms

@philrenaud philrenaud merged commit 2accf2f into release/1.8.x Jun 12, 2024
14 of 15 checks passed
@philrenaud philrenaud deleted the backport/16034-ui-bug-node-metadata-doesnt-show-up-in-the-ui-when-key-is-also-a-prefix-for-others/badly-obliging-walleye branch June 12, 2024 20:54
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants