Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nomad executor to execute rkt #232

Closed
wants to merge 1 commit into from
Closed

Use nomad executor to execute rkt #232

wants to merge 1 commit into from

Conversation

achanda
Copy link
Contributor

@achanda achanda commented Oct 8, 2015

This provides some extra benefits out of the box

This provides some extra benefits out of the box
@dadgar
Copy link
Contributor

dadgar commented Oct 8, 2015

Hey @achanda, I don't think we want to go down this route. The nomad executor uses cgroups and chroots when it can and since rkt does the same we would be nesting these. It will probably break rkt as well since not all the filesystem mounts are exposed to the chroot as well as making tracking the state of the processes confusing as the executor does a double fork. If there are issues with the rkt driver that would be fixed by using the executor, we should just add those functionalities to the rkt driver itself.

@achanda
Copy link
Contributor Author

achanda commented Oct 8, 2015

I see, thanks for the explanation.

@achanda achanda closed this Oct 8, 2015
@achanda achanda deleted the rkt_fixes branch October 8, 2015 01:34
@dadgar
Copy link
Contributor

dadgar commented Oct 8, 2015

Of course!

benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
Make sure to sync snapshot files before closing
@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants