Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove 32-bit ARM builds #23189

Merged
merged 3 commits into from
Jun 5, 2024
Merged

build: remove 32-bit ARM builds #23189

merged 3 commits into from
Jun 5, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 5, 2024 •
edited
Loading

We no longer intend to release 32-bit builds for any platform. We'd previously removed the builds for i386 on both Linux and Windows, but never got around to removing the ARM builds. Add a note about this deprecation in the release notes for 1.8.x.

Closes: https://github.com/hashicorp/nomad-enterprise/issues/1053

@tgross
build: remove 32-bit ARM builds
5e01ba3 
We no longer intend to release 32-bit builds for any platform. We'd previously
removed the builds for i386 on both Linux and Windows, but never got around to
removing the ARM builds. Add a note about this deprecation in the release notes
for 1.8.x.
@tgross tgross requested review from schmichael, david-yu and shoenig June 5, 2024 17:45
@tgross tgross added this to the 1.8.x milestone Jun 5, 2024
@tgross tgross marked this pull request as ready for review June 5, 2024 17:45
@tgross tgross requested review from a team as code owners June 5, 2024 17:45
tgross added a commit to hashicorp/nomad-autoscaler that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds
22ce0fe 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross tgross mentioned this pull request Jun 5, 2024
Merged
tgross added a commit to hashicorp/nomad-driver-podman that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds
5d571c3 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross tgross mentioned this pull request Jun 5, 2024
Merged
schmichael
schmichael approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

👋 For anyone ending up here because you're looking for 32bit ARM binaries I would encourage you to try building Nomad from source for your particular architecture. The 32 bit ARM landscape is extremely diverse and was never well served by the binary we did build. We strive to keep Nomad as easy as a go install to build yourself, so I encourage you read the Go toolchain's page on ARM to find the best settings for your target architecture: https://go.dev/wiki/GoArm

@shoenig
Copy link
Contributor

shoenig commented Jun 5, 2024

I think we should delete build_linux_arm.go as well

tgross added a commit to hashicorp/nomad-autoscaler that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds (#915)
9e23cf1 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross
Copy link
Member Author

tgross commented Jun 5, 2024 •
edited
Loading

I think we should delete build_linux_arm.go as well

Should we, given the note @schmichael left above? Or as we move away from this support is that likely to just be a red herring for anyone trying to figure out a go build workflow? It's being removed from the Makefile anyways. Done.

tgross added a commit to hashicorp/nomad-driver-podman that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds (#352)
57be144 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
tgross added a commit to hashicorp/nomad-pack that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds
7ff490e 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross tgross mentioned this pull request Jun 5, 2024
Merged
tgross added a commit to hashicorp/nomad-pack that referenced this pull request Jun 5, 2024
@tgross
build: remove 32-bit builds (#518)
09381ad 
We no longer intend to release 32-bit builds for any platform for Nomad
ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross
Copy link
Member Author

tgross commented Jun 5, 2024

I probably should have split this into 2 PRs, one for the docs and one for the build changes. I'll open separate PRs with just the docs for backporting to 1.8.x/1.8.x+ent

@tgross tgross merged commit 34f3444 into main Jun 5, 2024
21 checks passed
@tgross tgross deleted the build-remove-arm-32bit branch June 5, 2024 19:47
@tgross tgross added the backport/website This will backport PR changes to `stable-website` && the latest release-branch label Jun 5, 2024
tgross added a commit that referenced this pull request Jun 5, 2024
@tgross
docs: 32-bit build deprecation
19317f8 
Backport of docs from #23189 so we can
have the docs in the 1.8.x branch without the build changes themselves, which we
only want to land in 1.9.0.
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 5, 2024
Merged
@tgross tgross mentioned this pull request Jun 5, 2024
Merged
tgross added a commit that referenced this pull request Jun 5, 2024
@tgross
docs: 32-bit build deprecation (#23193)
69771f0 
Backport of docs from #23189 so we can
have the docs in the 1.8.x branch without the build changes themselves, which we
only want to land in 1.9.0.
angrycub added a commit to hashicorp/levant that referenced this pull request Jun 10, 2024
@angrycub
build: remove 32-bit builds
11a9adb 
We no longer intend to release 32-bit builds for any platform for Nomad ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
This was referenced Jun 10, 2024
Merged
Merged
angrycub added a commit to hashicorp/levant that referenced this pull request Jun 11, 2024
@angrycub
build: remove 32-bit builds (#541)
10061ff 
We no longer intend to release 32-bit builds for any platform for Nomad ecosystem projects.

Ref: hashicorp/nomad#23189
Ref: hashicorp/nomad-enterprise#1053
@tgross tgross mentioned this pull request Aug 1, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@david-yu david-yu david-yu approved these changes

@schmichael schmichael schmichael approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees
No one assigned
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch theme/build-infrastructure
Projects
None yet
Milestone
1.8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@tgross @shoenig @schmichael @david-yu