Stop trying to use mount for image based drivers #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2178 and allows using Docker and other image based drivers even when nomad is run as a non-root user. `client/allocdir` tests can be run as a non-root user to ensure this behavior and tests that rely on root or non-root users properly detect their effective user and skip instead of fail.
|
LGTM. Please remove the BC warning on changelog |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2178 and allows using Docker and other image based drivers even
when nomad is run as a non-root user.
client/allocdirtests can be run as a non-root user to ensure thisbehavior and tests that rely on root or non-root users properly detect
their effective user and skip instead of fail.
Switched some tests to use Image based isolation instead of No FS isolation to allow running more tests as non-root users.