Enable numeric pagination tokens #20299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
approved these changes
Apr 4, 2024
shoenig
approved these changes
Apr 4, 2024
Co-authored-by: Tim Gross <[email protected]>
gulducat
force-pushed
the
uint-pagination-tokens
branch
from
4c6ac1c to
b21f49b
Compare
philrenaud
pushed a commit
that referenced
this pull request
Apr 18, 2024
* enable uint64 pagination tokens, so they can be compared as numbers instead of strings * tokenize job ModifyIndex as uint64, so an new upcoming state index can paginate properly * test require->must
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19339 we will be creating a state index that sorts jobs by
ModifyIndex, in order to show most-recently-changed jobs at the top of the Nomad web UI, while continuing to sort appropriately with pagination.The current pagination logic assumes all
NextTokens arestrings, which results in odd paging behavior (including infinite loops!) when the token is actually a number, due to lexicographical ordering, e.g."10" < "2"This doesn't go as far as fully generalizing the
Paginator/Tokenizerrelationship (as might be done withcomparableorcmp.Orderedgenerics), but it adds support foruint64tokens for my immediate use case, and opens a door for further future flexibility.