Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommendation for maximum number of template dependencies #20259

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Apr 1, 2024

We don't have docs on this, just the warning in the CT logs that suggests 128 is an upper limit (per task, not per template): runner.go#L304. Given the debugging we did for #20234 #20163 hashicorp/consul-template#1898 it seems like good advice to have.

@tgross tgross added theme/docs Documentation issues and enhancements theme/template labels Apr 1, 2024
@tgross tgross marked this pull request as ready for review April 1, 2024 19:39
@tgross tgross added backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Apr 1, 2024
@tgross tgross requested a review from davemay99 April 3, 2024 20:38
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line theme/docs Documentation issues and enhancements theme/template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants