Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of deps: update consul-template to 0.37.4 to fix resource leak into release/1.5.x #20236

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #20234 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@tgross
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


A Nomad user reported an issue where template runner View.poll goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4.

Fixes: #20163


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@tgross tgross force-pushed the backport/deps-consul-template/reliably-finer-baboon branch from afe8915 to 6e00808 Compare March 27, 2024 17:19
@tgross tgross marked this pull request as ready for review March 27, 2024 17:19
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
@tgross tgross force-pushed the backport/deps-consul-template/reliably-finer-baboon branch from 6e00808 to 2377a2e Compare March 27, 2024 17:24
@tgross tgross merged commit 0f219fd into release/1.5.x Mar 27, 2024
23 of 25 checks passed
@tgross tgross deleted the backport/deps-consul-template/reliably-finer-baboon branch March 27, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants