Backport of cli: fix tls ca create command with -domain into release/1.7.x
#19911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/cli-fix-ca-create/intensely-accepted-coyote
branch
from
a5cb709 to
5c8abf2
Compare
lgfa29
deleted the
backport/cli-fix-ca-create/intensely-accepted-coyote
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19892 to be assessed for backporting due to the inclusion of the label backport/1.7.x.
The below text is copied from the body of the original PR.
The current implementation of the
nomad tls ca createcommand ovierrides the value of the-domainflag with"nomad"if no additional customization is provided.This results in a certificate for the wrong domain or an error if the
-name-constraintflag is also used.The logic for
IsCustom()also seemed reversed. If all custom fields are empty then the certificate is not customized, soIsCustom()should return false.Closes #19836
Overview of commits