Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

hashicorp / nomad Public

Notifications You must be signed in to change notification settings
Fork 2k
Star 15.1k

Code
Issues 1.5k
Pull requests 124
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Choose safer default advertise address#1955

Merged

schmichael merged 15 commits intomasterhashicorp/nomad:masterfrom b-fix-default-advertisehashicorp/nomad:b-fix-default-advertiseCopy head branch name to clipboard

Nov 10, 2016

+262-211

Conversation Commits15 (15)Checks Files changed

Commits

Commits on Nov 8, 2016

Choose safer default advertise address
schmichael
committed
Failure to resolve advertise address isn't fatal
schmichael
committed
Refactor getAdvertise into a func
schmichael
committed
Handle missing ports in addresses
schmichael
committed
Match old error messages
schmichael
committed
Move config normalization into config.go to ease testing
schmichael
committed

Commits on Nov 9, 2016

Fix int pointer formatting and server config test
schmichael
committed
Normalize configs for agent tests
schmichael
committed
Restore sync/atomic use for consistency
schmichael
committed
Fix test that fails now that advertise can't be localhost
schmichael
committed
Enable dev mode to allow using localhost in tests
schmichael
committed
Addresses are just addresses - no ports
schmichael
committed
Add unit test for missing port helper func
schmichael
committed
Fix typo in test
schmichael
committed
Fix comment
schmichael
committed

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.