Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] When Action output is long enough, keep a user scroll-anchored to the bottom into release/1.7.x #19465

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19452 to be assessed for backporting due to the inclusion of the label backport/1.7.x.

The below text is copied from the body of the original PR.


Uses overflow-anchor (shoutout to https://css-tricks.com/books/greatest-css-tricks/pin-scrolling-to-bottom/) to keep long-running or tall Actions outputs in the UI scrolled to the bottom.

Importantly, if the user scrolls AWAY from the bottom, let's say to carefully read an earlier log or copy it, the anchoring behaviour ceases (until they scroll back to the bottom again)

image

Resolves #19437


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/19437-ui-actions-should-keep-me-scrolled-to-the-bottom-in-the-web-ui/incredibly-patient-gator branch from d44f435 to 94781fe Compare December 13, 2023 20:19
@philrenaud philrenaud merged commit 2b6213f into release/1.7.x Dec 13, 2023
3 of 4 checks passed
@philrenaud philrenaud deleted the backport/19437-ui-actions-should-keep-me-scrolled-to-the-bottom-in-the-web-ui/incredibly-patient-gator branch December 13, 2023 20:20
Copy link

Ember Test Audit comparison

release/1.7.x 94781fe change
passes 1540 1540 0
failures 0 0 0
flaky 0 0 0
duration 10m 52s 907ms 10m 47s 359ms -05s 548ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants