Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Revert "deps: update go-metrics to v0.5.3 (#19190)" into release/1.7.x #19401

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #19374 to be assessed for backporting due to the inclusion of the label backport/1.7.x.

The below text is copied from the body of the original PR.


hashicorp/raft still uses armon/go-metrics which results in the incorrect global metric sink variable being used and metrics not being reported.

go-metrics can only be upgraded once all dependencies are also updated to use the new path.

Spot check:

❯ nomad operator metrics | jq . | grep raft
      "Name": "nomad.raft.apply",
      "Name": "nomad.raft.barrier",
      "Name": "nomad.raft.state.candidate",
      "Name": "nomad.raft.state.follower",
      "Name": "nomad.raft.state.leader",
      "Name": "nomad.raft.transition.heartbeat_timeout",
      "Name": "nomad.raft.commitNumLogs",
      "Name": "nomad.raft.leader.dispatchNumLogs",
      "Name": "nomad.raft.peers",
      "Name": "nomad.raft.commitTime",
      "Name": "nomad.raft.fsm.apply",
      "Name": "nomad.raft.fsm.enqueue",
      "Name": "nomad.raft.leader.dispatchLog",
      "Name": "nomad.raft.thread.fsm.saturation",
      "Name": "nomad.raft.thread.main.saturation",

Fixes #19369


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/revert-19190-deps-update-go-metrics/distinctly-relevant-terrapin branch from e137afe to 355691d Compare December 8, 2023 21:20
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit 0a0a750 into release/1.7.x Dec 8, 2023
18 of 19 checks passed
@lgfa29 lgfa29 deleted the backport/revert-19190-deps-update-go-metrics/distinctly-relevant-terrapin branch December 8, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants