Delegate default networking mode selection #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When docker sees that the mode is set to "default", it sets it to "bridge". This patch delegates this to docker so that we are safe if the default mode changes in docker.
|
I will close this for now, will include this one in another patch. |
This was referenced Feb 18, 2022
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
Use an RWMutex for inmem snapshot store
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When docker sees that the mode is set to "default", it
sets it to "bridge". This patch delegates this to docker
so that we are safe if the default mode changes in docker.