deps: Switch from mitchellh/cli to hashicorp/cli #19321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
added
type/enhancement
stage/needs-discussion
theme/dependencies
|
Should probably also add the old import to the list of forbidden packages semgrep rule |
angrycub
force-pushed
the
deps/switch_to_hashicorp_cli
branch
from
beeb51a to
cc29d36
Compare
tgross
added
the
stage/needs-rebase
jrasell
changed the title
jrasell
added
theme/cli
and removed
stage/needs-discussion
stage/needs-rebase
jrasell
added
backport/ent/1.7.x+ent
pkazmierczak
approved these changes
Dec 19, 2024
jrasell
added a commit
that referenced
this pull request
Dec 19, 2024
Co-authored-by: James Rasell <[email protected]>
jrasell
added a commit
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Charlie Voiselle <[email protected]> Co-authored-by: James Rasell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @angrycub!
This PR switches from the achieved
mitchellh/clito the internally maintainedhashicorp/cli. A semgrep rule is included to stop usage of this library in the future.The change is like-for-like, therefore my plan is to backport this to all active release branches. Additionally, backporting CLI bug fixes might be painful without this. If any reviewers think this is a bad idea, please let me know.
The remaining indirect reference is due to
github.com/hashicorp/go-secure-stdlib/listenerutilwhich has migrated the library on main, but not released this version. I have submitted a request for a release via hashicorp/go-secure-stdlib#151. Once released, we can followup with a dependency update PR to remove the indirect dependency.