Backport of cli: skip allocs with replacements on job restart into release/1.5.x #19160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-cli-job-restart-skip-replaced-allocs/physically-renewing-dolphin
branch
from
5f741ab to
bba2361
Compare
hc-github-team-nomad-core
force-pushed
the
backport/b-cli-job-restart-skip-replaced-allocs/physically-renewing-dolphin
branch
from
130b8c9 to
c6a3deb
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19155 to be assessed for backporting due to the inclusion of the label backport/1.5.x.
The below text is copied from the body of the original PR.
The
nomad job restartcommand should skip allocations that already have replacements. Restarting an allocation with a replacement is a no-op because the allocation status is terminal and the command's replacement monitor returns immediatelly.But by not skipping them, the effective batch size is computed incorrectly.
Overview of commits